-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: contexts material design icon picker #929
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
faf8738
to
36c15a4
Compare
Pushed a quick commit to address the icon color and rebased |
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
4009e8e
to
a79709e
Compare
@elzody I still don't see the icons in the navigation. Just me? |
They show up fine for me, and I'm assuming for @juliushaertl as well? 🤔 However, I do notice that when I refresh the page or the contexts are fetched from the backend, it returns null for each property, which is weird. Maybe it's related somehow? |
Here's what I see in the console. I tried restarting my NC server, didn't help:
|
Looks like it's still trying to pull an emoji from the backend instead of an icon? Interesting, I'll dig through it and see what I can find, then make another fix. Or maybe, are you still using any applications/contexts from before the icon picker was there and it was emojis? If so, maybe try removing all those and making new ones |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Material design icon picker for Contexts.
Part of #895