Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: contexts material design icon picker #929

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Mar 13, 2024

Material design icon picker for Contexts.

Part of #895

@elzody elzody added enhancement New feature or request 3. to review Waiting for reviews labels Mar 13, 2024
src/pages/Context.vue Outdated Show resolved Hide resolved
Base automatically changed from poc-multiple-tables to feat/contexts March 14, 2024 07:35
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well have to consider contrast, since the icons are white.

On a white screen, it's barely visible:
Screenshot from 2024-03-14 11-43-07

Looks dope on dark mode 😎 :
Screenshot from 2024-03-14 11-45-24

@juliusknorr
Copy link
Member

Pushed a quick commit to address the icon color and rebased

Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody merged commit 1f0f822 into feat/contexts Mar 14, 2024
37 checks passed
@elzody elzody deleted the feat/contexts-icon-picker branch March 14, 2024 13:28
@enjeck
Copy link
Contributor

enjeck commented Mar 14, 2024

@elzody I still don't see the icons in the navigation. Just me?
Screenshot from 2024-03-14 14-33-51

@elzody
Copy link
Contributor Author

elzody commented Mar 14, 2024

@elzody I still don't see the icons in the navigation. Just me?

They show up fine for me, and I'm assuming for @juliushaertl as well? 🤔

image

However, I do notice that when I refresh the page or the contexts are fetched from the backend, it returns null for each property, which is weird. Maybe it's related somehow?

@enjeck
Copy link
Contributor

enjeck commented Mar 14, 2024

Here's what I see in the console. I tried restarting my NC server, didn't help:

[Vue warn]: Error in callback for immediate watcher "context.iconName" (Promise/async): "Error: Cannot find module './😀.svg'"

found in

---> <NavigationContextItem> at src/modules/navigation/partials/NavigationContextItem.vue
       <NcAppNavigation>
         <Navigation> at src/modules/navigation/sections/Navigation.vue
           <NcContent>
             <App> at src/App.vue
               <Root>

@elzody
Copy link
Contributor Author

elzody commented Mar 14, 2024

Here's what I see in the console. I tried restarting my NC server, didn't help:

Looks like it's still trying to pull an emoji from the backend instead of an icon? Interesting, I'll dig through it and see what I can find, then make another fix.

Or maybe, are you still using any applications/contexts from before the icon picker was there and it was emojis? If so, maybe try removing all those and making new ones

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants